Skip to content

Added epsilon property to the vsim command #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 5, 2025
Merged

Added epsilon property to the vsim command #3723

merged 4 commits into from
Aug 5, 2025

Conversation

htemelski-redis
Copy link
Contributor

@htemelski-redis htemelski-redis commented Jul 31, 2025 •
edited
Loading

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added the new EPSILON property to the VSIM command
redis/redis#14223

vladvildanov
vladvildanov reviewed Aug 1, 2025
View reviewed changes
vladvildanov
vladvildanov reviewed Aug 1, 2025
View reviewed changes
@vladvildanov vladvildanov merged commit 64426cb into master Aug 5, 2025
67 of 68 checks passed
@vladvildanov vladvildanov deleted the vsim_epsilon branch August 5, 2025 10:30
vladvildanov pushed a commit that referenced this pull request Aug 6, 2025
@htemelski-redis @vladvildanov
Added epsilon property to the vsim command (#3723)
c3db173 
* added epsilon property to the vsim command

* fixed linter errors

* added async client test

* modified test to use async
@petyaslavova petyaslavova added the feature New feature label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladvildanov vladvildanov vladvildanov left review comments

@elena-kolevska elena-kolevska elena-kolevska approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@htemelski-redis @elena-kolevska @vladvildanov @petyaslavova